Repository navigation
Support @codama/nodes@1.10 optional array attributes - #117
Merged
lorisleiva merged 1 commit intoJul 27, 2026
Merged
Conversation
This PR upgrades the `@codama/*` dependencies to 1.10 and adapts the renderer to `@codama/nodes@1.10`, whose node array attributes are now optional (`Array<T> | undefined`). Array reads are guarded with `?? []` throughout, and the new `injectedValueNode` value kind now throws an explicit unsupported-node error.
lorisleiva
marked this pull request as ready for review
July 27, 2026 12:26
🦋 Changeset detectedLatest commit: 46d9231 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This was referenced Jul 27, 2026
lorisleiva
added a commit
that referenced
this pull request
Jul 27, 2026
This backports the optional-array fix (#117) to the 1.x maintenance line. Since `@codama/nodes@1.5.0`, node array attributes are optional (`Array<T> | undefined`) and factories like `structTypeNodeFromInstructionArgumentNodes([])` omit empty arrays, so fresh 1.x installs resolving `@codama/nodes` to 1.10.x crashed during rendering (the Rust counterpart of codama-idl/renderers-js#168). Array reads are guarded with `?? []` throughout the renderer, the new `injectedValueNode` value kind throws an explicit unsupported-node error, the `@codama/*` dependency ranges are raised to `^1.10.0` (`renderers-core` to `^1.3.11`), and the CI workflow now also publishes from the 1.x and 2.x branches.
lorisleiva
added a commit
that referenced
this pull request
Jul 27, 2026
This backports the optional-array fix (#117) to the 2.x maintenance line. Since `@codama/nodes@1.5.0`, node array attributes are optional (`Array<T> | undefined`) and factories like `structTypeNodeFromInstructionArgumentNodes([])` omit empty arrays, so fresh 2.x installs resolving `@codama/nodes` to 1.10.x crashed during rendering (the Rust counterpart of codama-idl/renderers-js#168). Array reads are guarded with `?? []` throughout the renderer, the new `injectedValueNode` value kind throws an explicit unsupported-node error, the `@codama/*` dependency ranges are raised to `^1.10.0` (`renderers-core` to `^1.3.11`), and the CI workflow now also publishes from the 1.x and 2.x branches.
lorisleiva
added a commit
that referenced
this pull request
Jul 27, 2026
This backports the optional-array fix (#117) to the 1.x maintenance line. Since `@codama/nodes@1.5.0`, node array attributes are optional (`Array<T> | undefined`) and factories like `structTypeNodeFromInstructionArgumentNodes([])` omit empty arrays, so fresh 1.x installs resolving `@codama/nodes` to 1.10.x crashed during rendering (the Rust counterpart of codama-idl/renderers-js#168). Array reads are guarded with `?? []` throughout the renderer, the new `injectedValueNode` value kind throws an explicit unsupported-node error, the `@codama/*` dependency ranges are raised to `^1.10.0` (`renderers-core` to `^1.3.11`), and the CI workflow now also publishes from the 1.x and 2.x branches.
lorisleiva
added a commit
that referenced
this pull request
Jul 27, 2026
This backports the optional-array fix (#117) to the 2.x maintenance line. Since `@codama/nodes@1.5.0`, node array attributes are optional (`Array<T> | undefined`) and factories like `structTypeNodeFromInstructionArgumentNodes([])` omit empty arrays, so fresh 2.x installs resolving `@codama/nodes` to 1.10.x crashed during rendering (the Rust counterpart of codama-idl/renderers-js#168). Array reads are guarded with `?? []` throughout the renderer, the new `injectedValueNode` value kind throws an explicit unsupported-node error, the `@codama/*` dependency ranges are raised to `^1.10.0` (`renderers-core` to `^1.3.11`), and the CI workflow now also publishes from the 1.x and 2.x branches.
lorisleiva
added a commit
that referenced
this pull request
Jul 27, 2026
This backports the optional-array fix (#117) to the 1.x maintenance line. Since `@codama/nodes@1.5.0`, node array attributes are optional (`Array<T> | undefined`) and factories like `structTypeNodeFromInstructionArgumentNodes([])` omit empty arrays, so fresh 1.x installs resolving `@codama/nodes` to 1.10.x crashed during rendering (the Rust counterpart of codama-idl/renderers-js#168). Array reads are guarded with `?? []` throughout the renderer, the new `injectedValueNode` value kind throws an explicit unsupported-node error, the `@codama/*` dependency ranges are raised to `^1.10.0` (`renderers-core` to `^1.3.11`), and the CI workflow now also publishes from the 1.x and 2.x branches.
lorisleiva
added a commit
that referenced
this pull request
Jul 27, 2026
This backports the optional-array fix (#117) to the 2.x maintenance line. Since `@codama/nodes@1.5.0`, node array attributes are optional (`Array<T> | undefined`) and factories like `structTypeNodeFromInstructionArgumentNodes([])` omit empty arrays, so fresh 2.x installs resolving `@codama/nodes` to 1.10.x crashed during rendering (the Rust counterpart of codama-idl/renderers-js#168). Array reads are guarded with `?? []` throughout the renderer, the new `injectedValueNode` value kind throws an explicit unsupported-node error, the `@codama/*` dependency ranges are raised to `^1.10.0` (`renderers-core` to `^1.3.11`), and the CI workflow now also publishes from the 1.x and 2.x branches.
lorisleiva
added a commit
that referenced
this pull request
Jul 28, 2026
This backports the optional-array fix (#117) to the 2.x maintenance line. Since `@codama/nodes@1.5.0`, node array attributes are optional (`Array<T> | undefined`) and factories like `structTypeNodeFromInstructionArgumentNodes([])` omit empty arrays, so fresh 2.x installs resolving `@codama/nodes` to 1.10.x crashed during rendering (the Rust counterpart of codama-idl/renderers-js#168). Array reads are guarded with `?? []` throughout the renderer, the new `injectedValueNode` value kind throws an explicit unsupported-node error, the `@codama/*` dependency ranges are raised to `^1.10.0` (`renderers-core` to `^1.3.11`), and the CI workflow now also publishes from the 1.x and 2.x branches.
lorisleiva
added a commit
that referenced
this pull request
Jul 28, 2026
This backports the optional-array fix (#117) to the 1.x maintenance line. Since `@codama/nodes@1.5.0`, node array attributes are optional (`Array<T> | undefined`) and factories like `structTypeNodeFromInstructionArgumentNodes([])` omit empty arrays, so fresh 1.x installs resolving `@codama/nodes` to 1.10.x crashed during rendering (the Rust counterpart of codama-idl/renderers-js#168). Array reads are guarded with `?? []` throughout the renderer, the new `injectedValueNode` value kind throws an explicit unsupported-node error, the `@codama/*` dependency ranges are raised to `^1.10.0` (`renderers-core` to `^1.3.11`), and the CI workflow now also publishes from the 1.x and 2.x branches.
lorisleiva
deleted the
07-27-support_codama_nodes_1.10_optional_array_attributes
branch
August 27, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the
@codama/*dependencies to 1.10 and adapts the renderer to@codama/nodes@1.10, whose node array attributes are now optional (Array<T> | undefined). Array reads are guarded with?? []throughout, and the newinjectedValueNodevalue kind now throws an explicit unsupported-node error.